[sui-node] Add heath check router to jsonrpc server #19433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
fixup: remove unnecessary metrics loop
johnjmartin
force-pushed
the
fullnode-healthchecks
branch
from
152d2a3
to
8fbbd96
Compare
bmwill
approved these changes
Sep 20, 2024
johnjmartin
force-pushed
the
fullnode-healthchecks
branch
from
8fbbd96
to
f44fe22
Compare
johnjmartin
added a commit
to johnjmartin/sui
that referenced
this pull request
Sep 20, 2024
## Description Copying over the health check from the https://github.com/MystenLabs/sui/blob/main/crates/sui-rest-api/src/health.rs into a route that's enabled by default on the fullnode. This should be removed once the REST api is enabled for all fullnodes ## Test plan tested locally usage example (on a local sui-node starting from genesis): ``` $ curl localhost:9000/health up% $ curl 'localhost:9000/health?threshold_seconds=10000' down% $ curl 'localhost:9000/health?threshold_seconds=1000000000' up% ``` --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [x] JSON-RPC: feature: adds a configurable health check endpoint for json rpc fullnodes to report down if too far behind - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
johnjmartin
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copying over the health check from the https://github.com/MystenLabs/sui/blob/main/crates/sui-rest-api/src/health.rs into a route that's enabled by default on the fullnode.
This should be removed once the REST api is enabled for all fullnodes
Test plan
tested locally
usage example (on a local sui-node starting from genesis):
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.