[GraphQL] Rework Event type #19654
Open
[GraphQL] Rework Event type #19654
+975
−732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-mysten
requested review from
amnn,
wlmyng,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
wlmyng
approved these changes
Oct 2, 2024
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
1193a6e
to
f736cd3
Compare
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
f736cd3
to
b7462cc
Compare
stefan-mysten
changed the title
stefan-mysten
force-pushed
the
gql_fix_events_schema_naming
branch
from
b7462cc
to
183a806
Compare
amnn
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Nice, thank you @stefan-mysten ! Could you also give a heads up to the SDK working group about this change and when it's expected to be released?
Definitely, thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accessing the
bcsfield of anEventis rather confusing, as it is not the whole event BCS encoded, but just the contents of it, more specifically, the BCS bytes of aMoveValue.This PR removes the #flatten in
Event, adds acontentsfield to the type, and adds thebcsfield to theEventtype which encodes the wholeEvent.Test plan
Existing tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
Eventtype has a new field calledcontents, which is the event's content value as aMoveValue. This replaces the previous scheme that flattened theMoveValuetype in theEventtype. It also added abcsfield which represents the Base64 encoded BCS serialized event.