[indexer] Simplify setting up a test indexer writer or reader #19663
+124
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlmyng
requested review from
amnn,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
wlmyng
force-pushed
the
indexer/cleanup-start-fns
branch
from
98aeae3
to
4c862a4
Compare
This was referenced Oct 2, 2024
…iating an indexer writer and reader into separate functions, and use those functions in tests where we previously clobbered everything into a single function.
wlmyng
force-pushed
the
indexer/cleanup-start-fns
branch
from
4c862a4
to
5399f84
Compare
|
This PR on its own may not have a great deal of context. While working on #19637, I found it difficult to juggle where exactly I had to update the |
emmazzz
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, tests that require spinning up an indexer do so through
start_test_indexer_implorstart_test_indexer. This is further complicated by a singlestartfunction that accepts aReaderWriterConfig. We can simplify this by exposing two functions with optional parameters that can be configured by the caller.Part of a stack of PRs for watermarks
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.