-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-compiler] public init for unit testing in debug build #20481
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the effort on this! And sorry for not getting back to this sooner.
As the comment suggests, we have an issue here where the Sui bytecode verifier needs special support for this on the unit testing side. You won't be able to see this in the tests just in external-crates, and it will be visible only on the Sui side.
This isn't something that can be solved with Rust's debug mode (#[cfg(debug_assertions)]
), since we release and build the CLI in release
mode
external-crates/move/crates/move-compiler/src/typing/translate.rs
Outdated
Show resolved
Hide resolved
...l-crates/move/crates/move-compiler/tests/move_2024/unit_test/cross_module_init_function.move
Outdated
Show resolved
Hide resolved
I try to do this in debug build, because the test coverage only work in debug build now. |
Now there is no debug_assertions in the PR, and it will effect in release build with sui-mode and the test now in sui-mode. |
Hi @tnowacki, |
Description
Provide
init
for unit test in debug build, please reference #20389.Test plan
cross_module_init_function.move
is added for make sure there is no change on the release baseline.Release notes
The release did no change any production level code.