chore: update narwhal pointer #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the narwhal pointer and include the change where the primary-to-primary interface was changed to use anemo (QUIC) vs gRPC. This wasn't expected to be a breaking change but turned out to be one due to the inability of an ipv4 udp socket from being able to send to an ipv6 address. This is due to narwhal unconditionally binding on an ipv4 address (0.0.0.0) while the addresses included in the committee structure are localhost which happens to first be resolved to ::1. The simple short-term workaround is to change our config generation to always use the ipv4 localhost address of 127.0.0.1.
bmwill
force-pushed
the
fix-narwhal
branch
2 times, most recently
from
38214ee
to
ba54c3c
Compare
arun-koshy
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the narwhal pointer and include the change where the primary-to-primary interface was changed to use anemo (QUIC) vs gRPC.
This wasn't expected to be a breaking change but turned out to be one due to the inability of an ipv4 udp socket from being able to send to an ipv6 address. This is due to narwhal unconditionally binding on an ipv4 address (0.0.0.0) while the addresses included in the committee structure are localhost which happens to first be resolved to ::1.
The simple short-term workaround is to change our config generation to always use the ipv4 localhost address of 127.0.0.1.
Fixes: MystenLabs/narwhal#929