Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track which validators are contributing towards tx and effects cert the most #4535

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

sadhansood
Copy link
Contributor

@sadhansood sadhansood commented Sep 8, 2022

With these couple metrics we can answer a simple question - how much a validator is contributing (or how valuable it is) with respect to building transaction and effects? But this visibility is lacking today and we aim to bride this gap with this diff.

@sadhansood sadhansood requested review from longbowlu, lxfind and gdanezis and removed request for longbowlu September 8, 2022 21:28
@sadhansood sadhansood marked this pull request as ready for review September 8, 2022 21:29
@sadhansood sadhansood force-pushed the sadhan/track_auth_agg_validators branch 2 times, most recently from 089f1ba to 6805369 Compare September 15, 2022 20:16
Copy link
Contributor

@longbowlu longbowlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@longbowlu
Copy link
Contributor

Once we enable epoch change, we need some extra logic to update authority aggregators. Do we have an issue to track this? cc @lxfind

@lxfind
Copy link
Contributor

lxfind commented Sep 19, 2022

Yes #2924

@sadhansood sadhansood force-pushed the sadhan/track_auth_agg_validators branch from 6805369 to 7202d6a Compare September 19, 2022 15:52
@sadhansood sadhansood enabled auto-merge (squash) September 19, 2022 15:56
@longbowlu
Copy link
Contributor

Yes #2924

not necessarily on fullnode. Load gen today uses its embedded quorum driver and will continue having this option.

@lxfind
Copy link
Contributor

lxfind commented Sep 19, 2022

Load gen today uses its embedded quorum driver and will continue having this option.

I would assume load gen using embedded quorum driver is only temporary? i.e. once fullnode + quorum driver stablizes, the load gen should just talk to the fullnode directly.

@sadhansood sadhansood merged commit fb4bbac into main Sep 19, 2022
@sadhansood sadhansood deleted the sadhan/track_auth_agg_validators branch September 19, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants