Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet adapter example README.md #4538

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Wallet adapter example README.md #4538

merged 1 commit into from
Sep 10, 2022

Conversation

punwai
Copy link
Contributor

@punwai punwai commented Sep 9, 2022

Just to not trip anyone up

@punwai punwai marked this pull request as ready for review September 9, 2022 01:03
@punwai punwai changed the title Create README.md Wallet adapter example README.md Sep 9, 2022
@punwai punwai enabled auto-merge (squash) September 9, 2022 06:57
Copy link
Contributor

@randall-Mysten randall-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use proper noun casing for product names. Added a suggested change to correct them. Thank you

@@ -0,0 +1,2 @@
#### Wallet Adapter Example
This folder contains an example react frontend that utilizes the wallet adapter. For the wallet-adapter source code, check out /wallet-adapter/packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This folder contains an example react frontend that utilizes the wallet adapter. For the wallet-adapter source code, check out /wallet-adapter/packages.
This folder contains an example React frontend that utilizes the Sui Wallet Adapter. You can view the Wallet Adapter source code in the /wallet-adapter/packages folder.

is it a frontend component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Randall! Apologies! I finished my internship last Friday and didn't see this. I set the PR on auto-merge, so as soon as Kostas approved it, it merged. I'll push through another PR to reflect your comments.

@punwai punwai merged commit 5589079 into main Sep 10, 2022
@punwai punwai deleted the punwai-patch-1 branch September 10, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants