Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert start_timer macro to function and start Instant there #4547

Merged
merged 1 commit into from
Sep 11, 2022
Merged

convert start_timer macro to function and start Instant there #4547

merged 1 commit into from
Sep 11, 2022

Conversation

longbowlu
Copy link
Contributor

@longbowlu longbowlu commented Sep 9, 2022 •
edited
Loading

a followup of #4536

thanks @andll for the suggestions!

@longbowlu longbowlu requested a review from andll September 9, 2022 17:46
@longbowlu longbowlu mentioned this pull request Sep 9, 2022
Merged
andll
andll approved these changes Sep 10, 2022
View reviewed changes
Copy link
Contributor

@andll andll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @longbowlu !

@longbowlu longbowlu merged commit 8414159 into main Sep 11, 2022
@longbowlu longbowlu deleted the timer-function-2 branch September 11, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andll andll andll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longbowlu @andll