Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explorer] Replaces broken image icon and uses as placeholder in owned objects #4656

Merged
merged 7 commits into from
Sep 16, 2022

Conversation

apburnie
Copy link
Contributor

This PR:

  • Inserts a placeholder image for owned NFTs that do not have an associated image
  • Updates the placeholder image used in the Object Results Page when the image URL is broken

An example NFT with a broken image URL could not be found. The example in the video is based on static JSON data.

Here's a video showing the changes

firefox_CUA5otSxae.mp4

@@ -84,6 +84,11 @@ div.display > div > img {
@apply max-h-[120px] w-full sm:max-w-[120px] ml-auto;
}

div.display > div > div > div,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this for now, but really don't like these deep tag selectors

@apburnie apburnie merged commit fb46db9 into main Sep 16, 2022
@apburnie apburnie deleted the emptyPlaceholderOwnedObj branch September 16, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants