[sui-system] minimum staking threshold of 1 SUI #9961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
The other missing piece that I didn't finish in #9825 is updating the benchmarking code of staking (I think it's still using small amounts that are smaller than 1 SUI) |
lxfind
approved these changes
Mar 27, 2023
emmazzz
force-pushed
the
staking_threshold
branch
from
7053433
to
8dc86f5
Compare
|
|
emmazzz
force-pushed
the
staking_threshold
branch
from
8dc86f5
to
3ca50cc
Compare
emmazzz
force-pushed
the
staking_threshold
branch
from
3ca50cc
to
7977c66
Compare
emmazzz
force-pushed
the
staking_threshold
branch
4 times, most recently
from
08ce463
to
ad44dfa
Compare
The threshold is set at the entry level to the Sui system object: the rewards to the validators might still be smaller than the threshold so we can't set it at the level of the staking pool.
emmazzz
force-pushed
the
staking_threshold
branch
from
ad44dfa
to
88a0076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Took over the work @dmitri-perelman started (and almost finished) in #9825 because I can't push to his fork of the repo.
Test Plan
Added some tests.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes