Add line and column numbers to error messages #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds line and column numbers to error messages from tokenize.rs via a new function make_syntax_error.
Adds the canonical filepath as well as the line/column numbers to the error message (eg. `/path/to/file:5:10`).
Changes the error message for a misplaced tag to a panic, since tokens outside functions should be ignored.
Adds line and column numbers to the macro error from preprocess.rs. This was done by adding two usizes to the MacroName token. This might not be the most efficient way to do it, but it was the fastest.
Fixes the column number being 1 higher than it should be due to the newline character incrementing the column integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
tokenize.rspreprocess.rs