Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimaps Skywars and Deathrun not regenerated fully #169

Closed
CodeRunner47 opened this issue Oct 10, 2016 · 8 comments
Closed

Minimaps Skywars and Deathrun not regenerated fully #169

CodeRunner47 opened this issue Oct 10, 2016 · 8 comments
Milestone

Comments

@CodeRunner47
Copy link

CodeRunner47 commented Oct 10, 2016

All,

I have issues with skywars not resetting (renerating) the islands after the game ends.
Ingame placed blocks are still on the islands, which mostly gives an advantage on a new game...

Minigameslab version is 1.14.11, my MGSkyWars version is also 1.14.11

A simular issue I have with MGDeathrun (v1.14.11). Also here the map doesn't get a total reset. And another issue is... On one map I have multiple floors, unfortunately the game ends before the player passes the low bound.....

@mepeisen
Copy link
Collaborator

First check if your arena bounds are including all your islands.
We have two other bugs, #168 and #152.
Maybe you can send me a worldedit of your arena to mep_eisen@web.de
I will try to reproduce it.

@mepeisen mepeisen added this to the 1.14.12 milestone Oct 15, 2016
@CodeRunner47
Copy link
Author

Thanx for the reply, I uploaded both schematics to you e-mail account (Skywars schematic and DeathRun schematic)
My high and low bounds in each game include the entire schematic. For SkyWars, the left behind blocks are being deleted after doing a manual reset of the game /sw reset [gamename]
DeathRun is something different, no matter what I do (set a worlguard region with infinity allow), the player that sinks thru the floor loses, even if he didn't pass the low bound.

@CodeRunner47
Copy link
Author

Ohw, did find another bug too, but I have seen a post on it in #152.
My shematic has some pools of water in them, if the water runs of the island and the game ends a trail of water just below the lower bound remains present...

@mepeisen
Copy link
Collaborator

For death run and the loses please see #126
I will try to fix lava and water during smart reset.

@mepeisen
Copy link
Collaborator

I played your deathrun arena with my bots several times. On spigot 1.10.2 all the blocks get restored.
Do you have a screenshot of a broke arena after playing?

The lava/water problem is identified. Smart reset does not catch all the physics events. I am working on it.
Please retry with latest snapshot if the other problems are gone.
http://nexus.xworlds.eu/nexus/content/repositories/mce-snapshots/com/github/MCE-Plugins/Minigames-All/1.14.12-SNAPSHOT/Minigames-All-1.14.12-20161016.083234-5-bin.zip

@CodeRunner47
Copy link
Author

Islands got restored on SkyBlock, but after the game ends, no one can enter it again.... :/
I have 2 skywars games, both were not accessible after game end.

@mepeisen
Copy link
Collaborator

Please retry with latest release.
https://github.com/MCE-Plugins/MInigames-All/releases/tag/v1.14.13

Are there any errors in console after game end? What color has the join sign?

@mepeisen mepeisen modified the milestones: 1.14.14, 1.14.12 Nov 12, 2016
@mepeisen
Copy link
Collaborator

closed because of no response

mepeisen added a commit to MysticCity/MGSkyWars that referenced this issue Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants