Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build script, update icons, update .desktop file, bump rev. #9

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Alex313031
Copy link

I use xsensors on the daily, and use this to get an updated version in i.e. Ubuntu (which comes with 0.70).

Added 16, 24, and 32 icon sizes, updated the .desktop file to point to the correct location and added keywords.

Created a build script that sets optimization flags, and prompts the user for --help, --clean, --gtk2, or --gtk3.
(Shows help, runs make clean, builds against GTK2, or builds against GTK3, respectively)

@Mystro256
Copy link
Owner

Mystro256 commented Mar 27, 2023 via email

@Alex313031
Copy link
Author

@Mystro256 Sorry for the shitty commit message lol I understand.

Yeah a bindir variable would be better.
As far as the icon changes, do you agree?

I dont wanna remove my build script. I have made a similar one for my forks of htop, nvtop, this repo, and geany. I frequently install linux distros on different machines and VMs, and it makes building and installing really quick for me.

SOOO, I would prefer if you cherry pick. Later, I could update the readme with better instructions and make another pull request.

@Alex313031
Copy link
Author

@Mystro256 Updated my pull request

  • Updated copyright, added my name to the about page

  • Added Escape keyboard shortcut to exit. I would like to make it Ctrl + Q like many other gtk apps, but could figure out how to make it eval two simultaneous keypresses.

  • Updated desktop to just use xsensors for the exec line, as this works no matter where it installed, negating the need for the @bindir@ logic you mentioned.

  • I left the buildscript, because we could still update the readme on building steps. The build script is just an easy way to build or clean the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants