Add deadlock avoidance in nstallGameView by manually terminating op…

…tional pack parser on view exit (fixes #140)
MythicApp · Aug 14, 2024 · 8381d21 · 8381d21
1 parent a8f78ce
commit 8381d21
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Mythic/Views/Unified/Sheets/InstallGameView.swift b/Mythic/Views/Unified/Sheets/InstallGameView.swift
@@ -37,7 +37,7 @@ struct InstallViewEvo: View {
 
                     if output.stdout.contains("Installation requirements check returned the following results:") {
                         if let match = try? Regex(#"Failure: (.*)"#).firstMatch(in: output.stdout) {
-                            Legendary.stopCommand(identifier: "install")
+                            Legendary.stopCommand(identifier: "parseOptionalPacks")
                             installationError = Legendary.InstallationError(errorDescription: .init(match.last?.substring ?? "Unknown Error"))
                             isInstallationErrorPresented = true
                             return
@@ -76,6 +76,9 @@ struct InstallViewEvo: View {
                     }
                 )
             }
+            .onDisappear {
+                Legendary.stopCommand(identifier: "parseOptionalPacks")
+            }
 
         if operation.current != nil {
             Text("Cannot fetch selected downloads while other items are downloading.")