feat: Add list view option to game library

[marcusziade]

Close #57
Close #37

• This PR adds a new list view option to the game library, allowing users to switch between the existing grid layout and a more compact list layout.

• The new GameListRow component can later be refactored to share more stuff from GameCard.swift but IMO is fine as is for now.

• Additionally, the layout config will persist as a user setting, as I think most want that.

• Accessibility support for GameListRow

• New localization strings

Grid view (currently the only option)

List view (New)

[marcusziade]

🤔 Not sure yet why CI fails...

Code compiles locally, as seen in the screenshots above. Is this something unexpected, @blackxfiied @jeremybosma ?

I've already updated the branch with latest main and fixed one call that no longer takes the option parameter.

[asxrow66]

dm me on discord for adding this stuff to the docs and other work you've done, my discord name is cullenroberts

[vapidinfinity]

🤔 Not sure yet why CI fails...

Code compiles locally, as seen in the screenshots above. Is this something unexpected, @blackxfiied @jeremybosma ?

I've already updated the branch with latest main and fixed one call that no longer takes the option parameter.

CI's been failling lately, unsure as to why; it may have something to do with the Package.resolved file, will check

[vapidinfinity]

I'll merge these changes soon, but I want to make some changes and 'Mythicify™' the vertical list.

[marcusziade]

Afaik these CI issues are due to commit #7400de5. There are compiler flags in the diff that didn't pass the CI check before it was merged. This branch wasn't failing until I updated it with main that had that broken commit merged to it.

Should be a simple revert to fix this and then redo that commit again later.

[marcusziade]

There's a setting in repo settings that requires CI to pass before a branch can merge. I'd suggest we enable that. There's also the auto-merge feature that complements the former.

[jeremybosma]

This looks so unbelievably stunning, however with moving the filtering to a popover you should probably add this somewhere next to the filter icon in the top navigation. Not sure if we should merge because this entire filter bar will be gone then.

[jeremybosma]

Will wait on those changes in both prs, looking awesome still. Let me know

[marcusziade]

We should merge both this and my other PRs. Then, iterate further.

None of my PRs conflict. I haven't done duplicate work. Just merge code and if there's a conflict, let me fix it, plz

[marcusziade]

Not sure if we should merge because this entire filter bar will be gone then.

Not sure what you mean. The filter system was already merged. This PR only adds the button that switches between grid and list layout.

[marcusziade]

@jeremybosma I'd prefer it if we'd have a little process to designs. So instead of me changing this PR with new design ideas on the fly, we'd merge this, close the issues asking for a list layout, then iterate further with improved UX. Also consider that I put a few hours of design work on this myself. I think it's very usable for an alpha, until we come up with better stuff. Also, this matter is out-of-scope from this PR. This is only about the list layout, not the filter toolbar.

What do you think?

[jeremybosma]

@jeremybosma I'd prefer it if we'd have a little process to designs. So instead of me changing this PR with new design ideas on the fly, we'd merge this, close the issues asking for a list layout, then iterate further with improved UX. Also consider that I put a few hours of design work on this myself. I think it's very usable for an alpha, until we come up with better stuff. Also, this matter is out-of-scope from this PR. This is only about the list layout, not the filter toolbar.

What do you think?

I understand and agree with you fully, btw my request was not about the list layout which looks very good, i was more so talking about the filter toolbar because it will probably be too odd on non-maximized windows

[jeremybosma]

I will design interface ideas for Mythic, any idea where to send them. Discord, Github or any other messaging platform? Imsg?

[vapidinfinity]

@marcusziade

Afaik these CI issues are due to commit #7400de5. There are compiler flags in the diff that didn't pass the CI check before it was merged. This branch wasn't failing until I updated it with main that had that broken commit merged to it.

Should be a simple revert to fix this and then redo that commit again later.

the compiler flags shouldn't affect the build ci, and it's very strange that they do.
will look tomorrow since school holidays start then

[marcusziade]

I will design interface ideas for Mythic, any idea where to send them. Discord, Github or any other messaging platform? Imsg?

depending on how advanced you wanna do it. i don't need pixel perfect designs but im able to give you that if you want.

if just sketches i think you can open an issue and attach screenshots?

[vapidinfinity]

Lacks "Mythicification", see DownloadsEvo.swift -> DownloadCard

[marcusziade]

sure

can you explain the thinking behind the naming convention, just for context? what is "Mythicification"?