Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename acceptance criteria #167

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Rename acceptance criteria #167

merged 4 commits into from
Sep 1, 2023

Conversation

leonlan
Copy link
Collaborator

@leonlan leonlan commented Sep 1, 2023

This PR:

Notes:

  • It is essential that you add a test when making code changes.
    This keeps the code coverage level up, and helps ensure the changes work as intended.
  • When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
  • Docstring additions must render correctly, including escapes and LaTeX.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #167 (d223942) into master (db88880) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          30       30           
  Lines         748      748           
=======================================
  Hits          744      744           
  Misses          4        4           
Files Changed Coverage Δ
alns/accept/AlwaysAccept.py 100.00% <100.00%> (ø)
alns/accept/MovingAverageThreshold.py 100.00% <100.00%> (ø)
alns/accept/RandomAccept.py 100.00% <100.00%> (ø)
alns/accept/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leonlan leonlan marked this pull request as ready for review September 1, 2023 06:23
@leonlan leonlan requested a review from N-Wouda September 1, 2023 06:28
Copy link
Owner

@N-Wouda N-Wouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leonlan leonlan merged commit 04991b6 into master Sep 1, 2023
7 checks passed
@leonlan leonlan deleted the rename-acceptance-criteria branch September 1, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename RandomWalk and WorseAccept?
2 participants