-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change boolean values from 1/0 to true/false #196
Conversation
I propose that in the Field Definitions section we include language like:
|
adding new field definition: boolean values to be JSON booleans, not strings
Proposal revised to reflect @jcn's recommendation to add new Field Definition. |
Look good to me |
I hereby call a vote on this proposal. Voting will be open for 7 full days, until 11:59PM UTC on December 6th. Please vote for or against the proposal, and include the organization for which you are voting in your comment. |
+1 from Stae |
+1 from PBSC |
+1 from Ride Report |
+1 from IBI Group |
+1 from Transit |
+1 from Lime |
+1 JUMP |
The vote on this is now closed, and it passes. Votes for:
There were no votes against. Much of the MobilityData team is traveling today, so we'll take next steps in the coming days! |
…before "Boolean values must be JSON booleans"…
We'd love to make this an official part of the spec, but first we need to see this change being implemented. Could you comment here if your organization has implemented this? @evansiroky @quicklywilliam @charlesjump @gcamp @contra @johnpena @madupras Others? |
Please see this comment in the other ticket: #182 (comment) |
As per the general consensus over on Issue #10
Because this is a breaking change, it would not be implemented until we move into the next major version. The issues been open for coming on 4 years, though, so once we're ready for the next major version, it would be great to include this change!