fix/psutil update #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in http://grodola.blogspot.com.br/2014/01/psutil-20-porting.html some process properties are now methods, thus `create_time` (a bound method) was being passed to the store to be saved, not the information you would get by calling it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was broken when saving monitoring information on
pypln.backendbecause we were passing to the MongoStore a bound method. Even if the Store code didn't break with that, we would not have the information we needed. This small patch fixes this issue.I could not run the tests because they hang indefinitely, so I'm trusting this didn't break them =)
@turicas can you take a look and, if ok, merge and publish a new package?