use Hashie:Mash instead of ObjectifiedHash #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I'll look at it after holidays. |
|
@NARKOZ hey, any chance to get it merged? I want to make errbit's tests pass badly :) |
|
Sorry for delay. Yes, I wasn't focusing on Ruby 1.8. Thank you, again. PS: noticed that I could cherry-pick 444b576 after pushing :( |
|
@NARKOZ thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use
Hashie:Mashinstead ofObjectifiedHash.ObjectifiedHashdoesn't work properly with ruby 1.8 as ruby 1.8 objects haveidmethod. Yeah, I know that you don't test this gem with ruby 1.8 but I think it's ok to useHashiegem here. There are only benefits from it (actuallyObjectifiedHashbreaks integration with Errbit. And yes, we still support ruby 1.8 :( )