Skip to content

Commit

Permalink
fix(GLTFExtensionsPlugin.d.ts): make all parameters optional (#908)
Browse files Browse the repository at this point in the history
* fix(GLTFExtensionsPlugin.d.ts): make all parameters optional

* fix(TileCompressionPlugin.d.ts): make all parameters optional

* fix(UnloadTilesPlugin.d.ts): make all parameters optional

* fix(TilesFadePlugin.d.ts): make all parameters optional

* fix(ReorientationPlugin.d.ts): make all parameters optional

* fix(GoogleCloudAuthPlugin.d.ts): add missing parameters
  • Loading branch information
sguimmara authored Jan 8, 2025
1 parent 82d89b1 commit 51cb07d
Show file tree
Hide file tree
Showing 6 changed files with 35 additions and 30 deletions.
12 changes: 6 additions & 6 deletions src/plugins/three/GLTFExtensionsPlugin.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import { GLTFLoaderPlugin, GLTFParser } from 'three/examples/jsm/loaders/GLTFLoa
export class GLTFExtensionsPlugin {

constructor( options: {
metadata: boolean,
rtc: boolean,
metadata?: boolean,
rtc?: boolean,

plugins: Array<( parser: GLTFParser ) => GLTFLoaderPlugin>,
plugins?: Array<( parser: GLTFParser ) => GLTFLoaderPlugin>,

dracoLoader: DRACOLoader | null,
ktxLoader: KTX2Loader | null,
autoDispose: boolean,
dracoLoader?: DRACOLoader | null,
ktxLoader?: KTX2Loader | null,
autoDispose?: boolean,
} );

}
7 changes: 6 additions & 1 deletion src/plugins/three/GoogleCloudAuthPlugin.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
export class GoogleCloudAuthPlugin {

constructor( options : { apiToken: string, autoRefreshToken?: boolean } );
constructor( options: {
apiToken: string,
autoRefreshToken?: boolean,
logoUrl?: string,
useRecommendedSettings?: boolean;
} );

}
12 changes: 6 additions & 6 deletions src/plugins/three/ReorientationPlugin.d.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
export class ReorientationPlugin {

constructor( options: {
up: '+x' | '-x' | '+y' | '-y' | '+z' | '-z',
recenter: boolean,
constructor( options?: {
up?: '+x' | '-x' | '+y' | '-y' | '+z' | '-z',
recenter?: boolean,

lat: number | null,
lon: number | null,
height: number,
lat?: number | null,
lon?: number | null,
height?: number,
} );

}
20 changes: 10 additions & 10 deletions src/plugins/three/TileCompressionPlugin.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ import { TypedArray } from 'three';

export class TileCompressionPlugin {

constructor( options: {
generateNormals: boolean,
disableMipmaps: boolean,
compressIndex: boolean,
compressNormals: boolean,
compressUvs: boolean,
compressPosition: boolean,
constructor( options?: {
generateNormals?: boolean,
disableMipmaps?: boolean,
compressIndex?: boolean,
compressNormals?: boolean,
compressUvs?: boolean,
compressPosition?: boolean,

uvType: TypedArray,
normalType: TypedArray,
positionType: TypedArray,
uvType?: TypedArray,
normalType?: TypedArray,
positionType?: TypedArray,
} );

}
6 changes: 3 additions & 3 deletions src/plugins/three/UnloadTilesPlugin.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
export class UnloadTilesPlugin {

constructor( options: {
delay: number,
bytesTarget: number,
constructor( options?: {
delay?: number,
bytesTarget?: number,
} );

}
8 changes: 4 additions & 4 deletions src/plugins/three/fade/TilesFadePlugin.d.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export class TilesFadePlugin {

constructor( options: {
maximumFadeOutTiles: number,
fadeRootTiles: boolean,
fadeDuration: number,
constructor( options?: {
maximumFadeOutTiles?: number,
fadeRootTiles?: boolean,
fadeDuration?: number,
} );

}

0 comments on commit 51cb07d

Please sign in to comment.