Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #517 - TCP Support #540

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

cjjacks
Copy link
Contributor

@cjjacks cjjacks commented Oct 23, 2024

Creating a new pull request for #517 without the formatting, linting and docker changes. Additionally incorporating feedback on address specifications

&& ln -sf /usr/bin/python3.9 /usr/bin/python

WORKDIR $PROJECT_HOME
RUN python3.9 -m pip install --upgrade pip setuptools poetry

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted Low

Sort these package names alphanumerically. See more on SonarCloud
@cjjacks cjjacks changed the title Issue 517 Issue #517 - TCP Support Oct 23, 2024
Copy link

sonarcloud bot commented Oct 24, 2024

@cjjacks cjjacks marked this pull request as ready for review October 24, 2024 18:37
@cjjacks cjjacks requested review from a team as code owners October 24, 2024 18:37
@cjjacks
Copy link
Contributor Author

cjjacks commented Oct 24, 2024

Closed the original PR (#521) as I felt it would be cleaner this way. This PR only includes the changes to streams and clients and incorporates the feedback from #521.

The docker based testing harness I used to stress test all the different network components is removed from this pr but can still be found in my personal fork here: https://github.com/cjjacks/AIT-Core/tree/issue-517-docker. The stress can be run by checking out that branch and running make network-test

Additionally, I merged master into this branch to incorporate the linting and formatting changes. All subsequent commits after the merge were done with the pre-commit hooks installed.

Let me know if there is any additional feedback. This time I will rebase and clean up the commit history after feedback so I dont end having to trash the PR if serious changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant