Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 76 - add option to pull hostname / port from config #83

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Issue 76 - add option to pull hostname / port from config #83

merged 2 commits into from
Aug 26, 2019

Conversation

Futabay
Copy link
Contributor

@Futabay Futabay commented Aug 26, 2019

Bring back self._hostname = kwargs.get('hostname', None) and self._port = kwargs.get('port', None) to pre 28ae827 state. Add hostname and port to SLE config parameter.

@Futabay Futabay requested review from a team as code owners August 26, 2019 01:00
MJJoyce
MJJoyce approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@MJJoyce MJJoyce merged commit b3fd389 into NASA-AMMOS:master Aug 26, 2019
@MJJoyce MJJoyce mentioned this pull request Aug 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJJoyce MJJoyce MJJoyce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Futabay @MJJoyce