Import SATF Library Sequence #1592

goetzrrGit · 2025-01-14T21:49:12Z

Closes #1591

Library Sequence Modal:

Introduced a new modal for importing a library sequence file.
Integrated the library modal with workspaces for seamless interaction.

Linting Bugfix:

Fixed an issue where the linter incorrectly reported errors for values within a valid range when multiple ranges were defined.
Fixed an issue where the linter incorrectly reported errors for command stems with no arguments.

Autocomplete Bugfix:

Improved autocomplete functionality to allow completion even with invalid variable types. The user will be notified of the invalid type within the editor and will need to manually correct it.

SATF/SASF Library

Fixed an issue where we were not generating the @model correctly.

TESTING

Download the attach file (banana_library.txt)
Rename it to banana_library.satf
Create a new workspace
In the middle panel underneath the 'create sequence' you should see a 'import library'
Click on 'import library' and select a parcel and library file ex. banana_library.satf
Verify the library gets imported and you see 3 sequences created

banana_library.txt

cohansen · 2025-01-14T22:41:18Z

Is this branch supposed to merge into #1574? It looks like a lot of the same changes.

goetzrrGit · 2025-01-15T14:54:17Z

Is this branch supposed to merge into #1574? It looks like a lot of the same changes.

Yeah it is branched from 1574 and since that was merged in the first 4 fell off. It should now all be new code

src/components/sequencing/Sequences.svelte

src/utilities/codemirror/codemirror-utils.ts

src/components/sequencing/Sequences.svelte

duranb · 2025-01-28T18:17:41Z

src/components/sequencing/Sequences.svelte

@@ -59,6 +61,34 @@
    const workspaceId = getSearchParameterNumber(SearchParameters.WORKSPACE_ID);
    goto(`${base}/sequencing/new${workspaceId ? `?${SearchParameters.WORKSPACE_ID}=${workspaceId}` : ''}`);
  }
+
+  async function importLibary(): Promise<void> {


typo in importLibary

Thanks for catching that

duranb · 2025-01-28T18:24:48Z

src/utilities/codemirror/codemirror-utils.ts

@@ -120,10 +120,10 @@ export function getDefaultVariableArgs(parameters: VariableDeclaration[]): strin
        return parameter.allowable_values && parameter.allowable_values.length > 0
          ? `"${parameter.allowable_values[0]}"`
          : parameter.enum_name
-            ? `${parameter.enum_name}`
+            ? `"${parameter.enum_name}"`


Can we update the test for this case?

Sure added a unit test to test this path

src/utilities/codemirror/codemirror-utils.ts

duranb · 2025-01-28T18:31:27Z

src/components/sequencing/Sequences.svelte

+          name: seqN.name,
+          parcel_id: parcel,
+          seq_json: '',
+          workspace_id: workspaceId ? workspaceId : -1,


This will use -1 if workspaceId is 0

ahhh, I fixed this.

workspace_id: workspaceId !== null ? workspaceId : -1

@duranb the dismissal here was to test sonarqube, consider this unresolved

duranb · 2025-01-28T18:40:03Z

src/components/sequencing/Sequences.svelte

+      return;
+    }
+    let contents = '';
+    try {


Should this try/catch prevent the logic from proceeding if it can't read the file? The importLibrarySequences effect might be better equipped to handle this logic and also return the contents. Then it can show a failure modal as well.

I moved things into the effects.importLibrarySequences so everything is handled there. Thank you for the suggestions

This modal allows you to select a parcel and import a library sequence file

The linter incorrectly reported errors for values within a valid range when multiple ranges were defined. For example, if the ranges were 5-10 and 11-20, the linter would erroneously flag the value 8 as invalid because it falls outside the 11-20 range, even though it is valid within the 5-10 range.

…invalid variable types. Allow autocomplete to succeed and show the ERROR parameter value. The user will see this error in the editor and manually have to fix it.

There shouldn't be any parenthesis and commas in the SeqN generation

sonarqubecloud · 2025-01-29T23:07:53Z

Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

joswig

testing sonarqube gate, not inspecting contents

testing sonarqube

goetzrrGit added feature New feature or request sequencing Anything related to the sequencing domain labels Jan 14, 2025

goetzrrGit requested review from cohansen, duranb and joswig January 14, 2025 21:49

goetzrrGit self-assigned this Jan 14, 2025

goetzrrGit requested a review from a team as a code owner January 14, 2025 21:49

goetzrrGit requested a review from AaronPlave January 14, 2025 21:49

goetzrrGit had a problem deploying to test-workflow January 14, 2025 21:49 — with GitHub Actions Failure

goetzrrGit had a problem deploying to test-workflow January 14, 2025 22:04 — with GitHub Actions Failure

goetzrrGit had a problem deploying to test-workflow January 14, 2025 22:05 — with GitHub Actions Failure

goetzrrGit force-pushed the import_satf_library branch from 4c910c8 to 98330e2 Compare January 15, 2025 14:52

goetzrrGit had a problem deploying to test-workflow January 15, 2025 14:52 — with GitHub Actions Failure

goetzrrGit had a problem deploying to test-workflow January 15, 2025 14:57 — with GitHub Actions Failure

goetzrrGit had a problem deploying to test-workflow January 15, 2025 14:58 — with GitHub Actions Failure

duranb requested changes Jan 17, 2025

View reviewed changes

goetzrrGit force-pushed the import_satf_library branch from 98330e2 to f45cb60 Compare January 22, 2025 16:58

goetzrrGit temporarily deployed to test-workflow January 22, 2025 16:58 — with GitHub Actions Inactive

duranb previously requested changes Jan 28, 2025

View reviewed changes

duranb temporarily deployed to test-workflow January 28, 2025 18:35 — with GitHub Actions Inactive

duranb reviewed Jan 28, 2025

View reviewed changes

goetzrrGit force-pushed the import_satf_library branch from b59789e to 5047f18 Compare January 28, 2025 22:02

goetzrrGit temporarily deployed to test-workflow January 28, 2025 22:02 — with GitHub Actions Inactive

goetzrrGit added 5 commits January 29, 2025 13:02

Bugfix allow for paths in Headers

91ed8bb

Library Sequence Modal

92cb7c6

This modal allows you to select a parcel and import a library sequence file

Hook up the library modal to workspaces

af0d89e

Improved autocomplete functionality by allowing completion even with …

e346f21

…invalid variable types. Allow autocomplete to succeed and show the ERROR parameter value. The user will see this error in the editor and manually have to fix it.

goetzrrGit and others added 2 commits January 29, 2025 13:05

Fix @model generation.

ed3a487

There shouldn't be any parenthesis and commas in the SeqN generation

fix buttons wrapping

d329635

goetzrrGit force-pushed the import_satf_library branch from 5047f18 to d329635 Compare January 29, 2025 23:07

goetzrrGit temporarily deployed to test-workflow January 29, 2025 23:07 — with GitHub Actions Inactive

joswig previously approved these changes Jan 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import SATF Library Sequence #1592

Import SATF Library Sequence #1592

goetzrrGit commented Jan 14, 2025 •

edited

Loading

cohansen commented Jan 14, 2025

goetzrrGit commented Jan 15, 2025

duranb Jan 28, 2025

goetzrrGit Jan 28, 2025

duranb Jan 28, 2025

goetzrrGit Jan 28, 2025

duranb Jan 28, 2025

goetzrrGit Jan 28, 2025

joswig Jan 29, 2025

duranb Jan 28, 2025

goetzrrGit Jan 28, 2025

sonarqubecloud bot commented Jan 29, 2025

joswig left a comment

Import SATF Library Sequence #1592

Are you sure you want to change the base?

Import SATF Library Sequence #1592

Conversation

goetzrrGit commented Jan 14, 2025 • edited Loading

cohansen commented Jan 14, 2025

goetzrrGit commented Jan 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 29, 2025

Quality Gate failed

joswig left a comment

Choose a reason for hiding this comment

goetzrrGit commented Jan 14, 2025 •

edited

Loading