Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce parameter form number inputs #989

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

AaronPlave
Copy link
Contributor

Chips away at #939 but does not provide any general solution. This PR adds a debounce to parameter form number inputs to prevent serious performance degradation when user holds an arrow key to change the number in an input. This does not however address larger concerns of input lag/staleness/focus behavior.

To test:

  1. Make a plan with activities
  2. Click on an activity with numerical params, try banananation ParameterTest to really assess worst case performance.
  3. Spam number input changes with up and down arrow keys
  4. The updates should only come at the beginning and end of the sequence of changes.

@AaronPlave AaronPlave requested a review from a team as a code owner November 7, 2023 19:30
@AaronPlave AaronPlave self-assigned this Nov 7, 2023
@AaronPlave AaronPlave added the fix A bug fix label Nov 7, 2023
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely!

@AaronPlave AaronPlave force-pushed the feat/debounce-param-form-number-inputs branch from 429bf50 to 21e10f7 Compare November 9, 2023 00:47
@AaronPlave AaronPlave force-pushed the feat/debounce-param-form-number-inputs branch from 21e10f7 to c6016c2 Compare November 9, 2023 01:02
@AaronPlave AaronPlave merged commit 2f05931 into develop Nov 9, 2023
@AaronPlave AaronPlave deleted the feat/debounce-param-form-number-inputs branch November 9, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants