External profiles in procedural scheduling #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelCourtney
had a problem deploying
to
e2e-test
GitHub Actions
Failure
JoelCourtney
had a problem deploying
to
e2e-test
GitHub Actions
Failure
JoelCourtney
force-pushed
the
feat/proc-external-profiles
branch
from
2b17006 to
268cc46
Compare
JoelCourtney
had a problem deploying
to
e2e-test
GitHub Actions
Failure
JoelCourtney
had a problem deploying
to
e2e-test
GitHub Actions
Failure
dandelany
changed the title
JoelCourtney
had a problem deploying
to
e2e-test
GitHub Actions
Failure
JoelCourtney
force-pushed
the
feat/proc-external-profiles
branch
from
1c7a11d to
d482740
Compare
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
JoelCourtney
changed the title
JoelCourtney
force-pushed
the
feat/proc-external-profiles
branch
from
d482740 to
fbd02bc
Compare
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
JoelCourtney
force-pushed
the
feat/proc-external-profiles
branch
from
fbd02bc to
0f1c970
Compare
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
|
skovati
reviewed
Sep 30, 2024
JoelCourtney
force-pushed
the
feat/proc-external-profiles
branch
from
0f1c970 to
5a098ca
Compare
They are effectively the same requirement, but SerialSegmentOps refers to what the timeline IS and CoalesceSegmentsOp refers to what the timeline DOES. "is" is more appropriate in this case
JoelCourtney
force-pushed
the
feat/proc-external-profiles
branch
from
2918aa4 to
2c02928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
resource(...)method to thePlanobject, with the exact same semantics assimResults.resource(...). I put it onPlan, because it is statically known data that doesn't change with simulation.Verification
This PR also refactors some e2e tests to make a dedicated package for procedural scheduling, including building goals inside the e2e package. And it adds a couple tests for both the AeriePostgresPlan object and the main scheduler backend.
Documentation
docs pr
Future work