Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat argument fixes #9

Closed
camargo opened this issue Feb 16, 2023 · 0 comments · Fixed by #10
Closed

Repeat argument fixes #9

camargo opened this issue Feb 16, 2023 · 0 comments · Fixed by #10
Assignees
Labels
breaking change A change that will require updating downstream code refactor A code change that neither fixes a bug nor adds a feature

Comments

@camargo
Copy link
Member

camargo commented Feb 16, 2023

We need to:

  1. Remove the nested repeat argument since it's not supported in the AMPCS command dictionary spec:
    "$ref": "#/$defs/repeat_argument"
  2. Make the repeat arg an array of arrays so we can actually repeat the arguments.
    "value": {

We should add tests that cover both of these changes.

@camargo camargo added feature A new feature or feature request breaking change A change that will require updating downstream code labels Feb 16, 2023
@camargo camargo added this to Aerie Feb 16, 2023
@github-project-automation github-project-automation bot moved this to Todo in Aerie Feb 16, 2023
@camargo camargo moved this from Todo to In Review in Aerie Feb 16, 2023
@camargo camargo added refactor A code change that neither fixes a bug nor adds a feature and removed feature A new feature or feature request labels Feb 16, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Aerie Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that will require updating downstream code refactor A code change that neither fixes a bug nor adds a feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants