Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeat arg fixes #10

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Repeat arg fixes #10

merged 3 commits into from
Feb 16, 2023

Conversation

cohansen
Copy link
Collaborator

@cohansen cohansen commented Feb 16, 2023 •
edited
Loading

Closes #9.

I updated the repeat arg description as well to remove the nested information.
I also added an invalid test for nested repeat args.

@cohansen cohansen requested a review from camargo February 16, 2023 21:03
@cohansen cohansen self-assigned this Feb 16, 2023
@camargo camargo added feature A new feature or feature request refactor A code change that neither fixes a bug nor adds a feature labels Feb 16, 2023
@camargo camargo changed the title Fix/repeat arg fixes Repeat arg fixes Feb 16, 2023
camargo
camargo approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get sign off from Taifun and we can merge

camargo
camargo reviewed Feb 16, 2023
View reviewed changes
schema.json Outdated Show resolved Hide resolved
@camargo camargo added breaking change A change that will require updating downstream code and removed feature A new feature or feature request labels Feb 16, 2023
@camargo camargo merged commit 252e2a2 into develop Feb 16, 2023
@camargo camargo deleted the fix/repeat-arg-fixes branch February 16, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camargo camargo camargo approved these changes

Assignees

@cohansen cohansen

Labels
breaking change A change that will require updating downstream code refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeat argument fixes
2 participants
@cohansen @camargo