Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch TypeScript types #17

Merged
merged 1 commit into from
May 16, 2023
Merged

Patch TypeScript types #17

merged 1 commit into from
May 16, 2023

Conversation

camargo
Copy link
Member

@camargo camargo commented May 16, 2023

@camargo camargo self-assigned this May 16, 2023
@camargo camargo added the refactor A code change that neither fixes a bug nor adds a feature label May 16, 2023
goetzrrGit
goetzrrGit approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can come up with a regex to inject the new request filed in another PR.

@camargo camargo force-pushed the dev/patch-types branch from e01f300 to 27e51f7 Compare May 16, 2023 19:40
@camargo
Patch TypeScript types
f1acc03 
* Fixes bug in TypeScript gen
@camargo camargo force-pushed the dev/patch-types branch from 27e51f7 to f1acc03 Compare May 16, 2023 19:48
goetzrrGit
goetzrrGit approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the changes. I tested it on my end

@camargo camargo merged commit 16a743b into develop May 16, 2023
@camargo camargo deleted the dev/patch-types branch May 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetzrrGit goetzrrGit goetzrrGit approved these changes

Assignees

@camargo camargo

Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camargo @goetzrrGit