Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add new checks shelby #236

Merged
merged 12 commits into from
May 19, 2023

Conversation

svbagwell
Copy link
Contributor

Added License URL description check
Files edited:

  • rule_mapping.json
  • check_messages.json

Added Jenny as a reviewers. Sydney and Sheyenne can be option reviewers if they want the practice of reviewing a PR.

@svbagwell svbagwell requested review from jenny-m-wood, a user and smk0033 April 19, 2023 15:06
Copy link
Collaborator

@jenny-m-wood jenny-m-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but otherwise looks good!

pyQuARC/schemas/rule_mapping.json Outdated Show resolved Hide resolved
pyQuARC/schemas/rule_mapping.json Show resolved Hide resolved
pyQuARC/schemas/rule_mapping.json Show resolved Hide resolved
Copy link
Collaborator

@jenny-m-wood jenny-m-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but otherwise LGTM

pyQuARC/schemas/rule_mapping.json Outdated Show resolved Hide resolved
pyQuARC/schemas/rule_mapping.json Show resolved Hide resolved
Copy link
Collaborator

@jenny-m-wood jenny-m-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@svbagwell svbagwell merged commit 7ccd425 into feature-add_new_checks May 19, 2023
@svbagwell svbagwell deleted the feature-add_new_checks-shelby branch May 19, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants