Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Product Check added #239

Merged
merged 3 commits into from
May 1, 2023

Conversation

smk0033
Copy link
Contributor

@smk0033 smk0033 commented Apr 21, 2023

Added a Standard Product Check

@smk0033 smk0033 requested a review from svbagwell April 21, 2023 20:36
@jenny-m-wood jenny-m-wood self-requested a review April 24, 2023 20:24
Copy link
Contributor

@svbagwell svbagwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a separate check for DIF due to the schema not having a dedicated field for StandardProduct. Need a second set of eyes on this before merging, @jenny-m-wood can you take a look at the updates?

@smk0033 you did great! this was a funky one

Copy link
Collaborator

@jenny-m-wood jenny-m-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working correctly - just a few minor changes to the check_messages needed.

pyQuARC/schemas/check_messages.json Outdated Show resolved Hide resolved
pyQuARC/schemas/check_messages.json Outdated Show resolved Hide resolved
pyQuARC/schemas/rule_mapping.json Outdated Show resolved Hide resolved
pyQuARC/schemas/check_messages.json Outdated Show resolved Hide resolved
pyQuARC/schemas/check_messages.json Outdated Show resolved Hide resolved
@svbagwell svbagwell merged commit 5e9d21c into feature-add_new_checks May 1, 2023
@svbagwell svbagwell deleted the feature-add_new_checks_shey branch May 1, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants