Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Minor Inconsistencies #248

Merged
merged 3 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions pyQuARC/schemas/check_messages.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
{
"free_and_open_data_presence_check":{
"free_and_open_data_presence_check": {
"failure": "No FreeAndOpenData value was given.",
"help": {
"message": "",
"url": "https://wiki.earthdata.nasa.gov/display/CMR/Use+Constraints"
},
"remediation": "Recommend providing a FreeAndOpenData value of 'true'."
},

"datetime_format_check": {
"failure": "`{}` does not adhere to the ISO 1601 standard.",
"help": {
Expand Down Expand Up @@ -608,6 +607,14 @@
},
"remediation": "Please add a GCMD compliant campaign/project name if applicable to the dataset."
},
"granule_campaign_name_presence_check": {
"failure": "The campaign/project name is missing.",
"help": {
"message": "",
"url": "https://wiki.earthdata.nasa.gov/display/CMR/Project"
},
"remediation": "Please add a GCMD compliant campaign/project name if applicable to the dataset."
},
"spatial_coverage_type_presence_check": {
"failure": "The Spatial Coverage Type is missing.",
"help": {
Expand Down Expand Up @@ -640,22 +647,6 @@
},
"remediation": "Recommend providing at least one Online Resource URL."
},
"online_access_url_description_check": {
"failure": "There does not appear to be a description for the Online Access URL(s).",
"help": {
"message": "",
"url": "https://wiki.earthdata.nasa.gov/display/CMR/Related+URLs"
},
"remediation": "Recommend providing a description for each URL that is provided."
},
"online_resource_url_description_check": {
"failure": "There does not appear to be a description for the Online Resource URL(s).",
"help": {
"message": "",
"url": "https://wiki.earthdata.nasa.gov/display/CMR/Related+URLs"
},
"remediation": "Recommend providing a description for each URL that is provided."
},
"opendap_url_location_check": {
"failure": "The provided Online Access URL `{}` is an OPeNDAP URL.",
"help": {
Expand Down
88 changes: 25 additions & 63 deletions pyQuARC/schemas/rule_mapping.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{

"free_and_open_data_presence_check": {
"rule_name": "Free and Open Data Presence Check",
"fields_to_apply": {

"echo-c": [
{
"fields": [
Expand All @@ -25,12 +23,10 @@
]
}
]

},
"severity": "warning",
"check_id": "one_item_presence_check"
},

"data_update_time_logic_check": {
"rule_name": "Data Update Time Logic Check",
"fields_to_apply": {
Expand Down Expand Up @@ -2639,7 +2635,7 @@
]
},
"severity": "info",
"check_id": "one_item_presence_check"
"check_id": "one_item_presence_check"
},
"standard_product_check": {
"rule_name": "Standard Product Check",
Expand All @@ -2650,7 +2646,7 @@
"Collection/StandardProduct"
]
}
],
],
"umm-c": [
{
"fields": [
Expand Down Expand Up @@ -3539,13 +3535,6 @@
]
}
],
"echo-g": [
{
"fields": [
"Granule/Campaigns/Campaign/ShortName"
]
}
],
"dif10": [
{
"fields": [
Expand All @@ -3559,6 +3548,20 @@
"Projects/ShortName"
]
}
]
},
"severity": "warning",
"check_id": "one_item_presence_check"
},
"granule_campaign_name_presence_check": {
"rule_name": "Campaign Name Presence Check",
"fields_to_apply": {
"echo-g": [
{
"fields": [
"Granule/Campaigns/Campaign/ShortName"
]
}
],
"umm-g": [
{
Expand All @@ -3568,7 +3571,7 @@
}
]
},
"severity": "warning",
"severity": "info",
"check_id": "one_item_presence_check"
},
"spatial_coverage_type_presence_check": {
Expand Down Expand Up @@ -3669,55 +3672,6 @@
"severity": "error",
"check_id": "one_item_presence_check"
},
"online_access_url_description_check": {
"rule_name": "Online Access URL Description Check",
"fields_to_apply": {
"echo-c": [
{
"fields": [
"Collection/OnlineAccessURLs/OnlineAccessURL/URLDescription"
]
}
],
"echo-g": [
{
"fields": [
"Granule/OnlineAccessURLs/OnlineAccessURL/URLDescription"
]
}
]
},
"severity": "warning",
"check_id": "one_item_presence_check"
},
"online_resource_url_description_check": {
"rule_name": "Online Resource URL Description Check",
"fields_to_apply": {
"echo-c": [
{
"fields": [
"Collection/OnlineResources/OnlineResource/Description"
]
}
],
"echo-g": [
{
"fields": [
"Granule/OnlineResources/OnlineResource/Description"
]
}
],
"umm-g": [
{
"fields": [
"RelatedUrls/Description"
]
}
]
},
"severity": "warning",
"check_id": "one_item_presence_check"
},
"opendap_url_location_check": {
"rule_name": "ECHO10 OPeNDAP URL Location Check",
"fields_to_apply": {
Expand Down Expand Up @@ -4777,6 +4731,14 @@
"RelatedUrls/URL"
]
}
],
"umm-g": [
{
"fields": [
"RelatedUrls/Description",
"RelatedUrls/URL"
]
}
]
},
"severity": "warning",
Expand Down