Update for mono repo #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayeaye
reviewed
Feb 26, 2024
slesaad
force-pushed
the
update-for-mono-repo
branch
from
ccd84c2 to
bb82260
Compare
slesaad
force-pushed
the
update-for-mono-repo
branch
from
bb82260 to
7848094
Compare
anayeaye
approved these changes
Feb 29, 2024
anayeaye
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Adding a comment to this review: the change is potentially breaking for our existing veda-auth deployments because of the resource identifier change. The same functionality will be persisted but may cause us to have to cycle changes through the lower stages if user pools are recreated.
…sion instead of fixed
…on-latest fix: update aws-cdk=lib and aws_cdk.aws_cognito_identitypool_alpha versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://github.com/NASA-IMPACT/veda-deploy/issues/25
Description
Changes to make sure this works well with the mono repo deployment
Changes
veda-deployveda-deploy