Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fixes for newer aws-cdk version and automated branch deployments #24

Merged
merged 17 commits into from
Mar 5, 2024
Merged

fix(ci): fixes for newer aws-cdk version and automated branch deployments #24

merged 17 commits into from
Mar 5, 2024

Conversation

anayeaye
Copy link
Contributor

@anayeaye anayeaye commented Mar 4, 2024 •
edited
Loading

What

Minimum viable branch and push cicd updates and various fixes

  • updated aws-cdk version requires additional cdk context "@aws-cdk/customresources:installLatestAwsSdkDefault": false
  • cicd.yml simplified (for now) to automatically deploy on dev and main branches. In the future we may want to implement the pattern of calling the cdk-actions/workflow that is used for production for the lower environments as well but today the lower environment aws setup lacks the appropriate deployment role
  • stop creating an additional copy of the workflows client secret with appended duplicate values with veda_ in keys (workflows client no longer used this way)

How tested

Temporarily executed cdk deploy to dev stack on push to this fix branch.

@anayeaye anayeaye deployed to development March 4, 2024 22:42 — with GitHub Actions Active
@anayeaye anayeaye changed the title ci: verbose cdk diff fix(ci): fixes for newer aws-cdk version and automated branch deployments Mar 4, 2024
slesaad
slesaad reviewed Mar 4, 2024
View reviewed changes
infra/stack.py
CfnOutput(
self,
f"cognito-app-{service_id}-secret",
export_name=f"{stack_name}-cognito-app-secret",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the secret we're passing to veda-data-airflow, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so airflow uses the veda-workflows auth client? I will duplicate this output in app.py. The other app.py cfn output that was added for the programmatic client was causing duplicate export names so I removed this inner cfn output to let the new one you added for sdk win.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that won't work either. I may need to walk back some changes and try and handle the duplicate identifier bug in a different way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it uses this export name - {stack_name}-cognito-app-secret

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed this here 7adb071

@anayeaye anayeaye marked this pull request as draft March 4, 2024 23:37
@anayeaye anayeaye marked this pull request as ready for review March 5, 2024 00:44
@anayeaye anayeaye merged commit ed29ead into dev Mar 5, 2024
3 checks passed
@anayeaye anayeaye deleted the fix/ci-for-dev branch March 5, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slesaad slesaad slesaad left review comments

@smohiudd smohiudd smohiudd approved these changes

@botanical botanical Awaiting requested review from botanical

@ividito ividito Awaiting requested review from ividito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anayeaye @slesaad @smohiudd