Skip to content

Commit

Permalink
Reflect comments
Browse files Browse the repository at this point in the history
  • Loading branch information
hanbyul-here committed Sep 12, 2024
1 parent c1ed6b8 commit c4d137b
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions app/scripts/components/exploration/data-utils-no-faux-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,16 @@ export function resolveRenderParams(
return datasetSourceParams;
}

// Check for the dashboard render configuration in queryData if not defined.
const renderKey = queryDataRenders?.dashboard? 'dashboard' : datasetSourceParams?.assets;
if (!queryDataRenders?.[renderKey]) throw new Error ('No proper render parameter exists.');
// Check for the dashboard render configuration in queryData
if (!queryDataRenders) throw new Error ('No proper render parameter exists.');

// Check the namespace from render extension
const renderKey = queryDataRenders.dashboard? 'dashboard' : datasetSourceParams?.assets;
if (!queryDataRenders[renderKey]) throw new Error ('No proper render parameter exists.');

// Return the render extension parameter
if (queryDataRenders[renderKey] && hasValidSourceParams(queryDataRenders[renderKey])) {
const renderParams = queryDataRenders.dashboard;
const renderParams = queryDataRenders[renderKey];
return {
...renderParams,
rescale: flattenAndCalculateMinMax([renderParams.rescale])
Expand Down

0 comments on commit c4d137b

Please sign in to comment.