-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie Consent - Clean up #1171
Comments
@hanbyul-here do we have a place to document all current feature flags for instance owners? I think this could be a good thing to document somewhere, and specifically on the cookie consent form we might want to define:
|
@aboydnw There is this file: https://github.com/NASA-IMPACT/veda-ui/blob/main/docs/content/CONFIGURATION.md, which has all the configuration-related documents. These documents are mainly for developers, so they miss some elements, such as when people should use it 🤔 I feel like these elements should be handled separately from dev docs - but not sure where it should go though, do you have an idea about where to put these kinds of docs? |
**Related Ticket:** #1171 ### Description of Changes - Relocating cookie retrieval, validation, and creation functionality from `layoutRoot` to `cookieConsentForm` - Implementing `session item` to track when a session has begun for each individual user and only run validation and retrieval functionality on session start and when a response has not been recorded. - Adjusting Banner content to accept markdown in config props. ### Notes & Questions About Changes ### Validation / Testing Clear out all cookies in your local machine to do so: open `dev tools` -> navigate to `application tab`-> navigate to `cookies` in the left panel -> right click `clear` - After clearing your existing site cookies, navigate to any page. Click on **Decline**. Navigate to another page and you should not see the cookie consent form component. - Clearing your existing site cookies again, navigate to any page. Click on **Accept**. Navigate to another page and you should not see the cookie consent form component. - Clearing your existing site cookies again, navigate to any page. Click on **X**. Navigate to another page and you should see the cookie consent form component rerendered.
Notes from feedback on original Cookie Consent Form work:
The text was updated successfully, but these errors were encountered: