Remove minHeight prop #1265
Remove minHeight prop #1265
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@dzole0311 isn't that prop needed for the default solid color fill in case an image isn't provided? |
|
@slesaad I had to clean up my local cache (was switching between the Next.js repo and this one) before I noticed the problem 🤦 I pushed one more change, and would appreciate another look! Also, I’ve updated our mock data to exclude the image for one of the cards which makes it easier to spot if something looks odd in next releases. |
|
GHG Center preview: https://deploy-preview-667--ghg-demo.netlify.app/ |
There was a problem hiding this comment.
Manual testing looks good to me. Although I'm not sure the answer to @slesaad 's question:
isn't that prop needed for the default solid color fill in case an image isn't provided?
Did we confirm the default solid color fill still works as expected? I couldn't find an example in the preview link.
|
@aboydnw - @dzole0311 fixed that issue in the new commit, there's an example in this page https://deploy-preview-1265--veda-ui.netlify.app/stories |
### 🚀 Improvements * Exploration & Analysis core VEDA feature breakout #1251 #1154 * Introduce `EnvConfigProvider` to simplify the injection of environment variables from host applications like Next.js #1253 * Remove React Router's `useNavigate` dependency for simplifying the routing #1270 ### 🐛 Fixes * Fix an issue where card images fail to maintain the correct aspect ratio #1265
Related Ticket: #1264
Description of Changes
Removed minHeight prop to avoid undesired card behavior. The css prop was introduced here: #1244
Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing
Or see the Air Quality card here: