Address QA review of stage/v0.6.0 #451
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Good catch about the polyline encoding.
Replaced the separator with a semicolon ; which is not present in the polyline.
Are you 100% sure of that? I couldn't find any info on what characters are included or not.
Additionally, I'm not sure semicolons are safe to use in URLs, see
Maybe a safer bet would be to use a longer string?
I'm also wondering if at this point we should provide retrocompatibility to URLs formed in a previous version (probably not; although something to keep in mind)
|
@nerik According to the polyline encoding they add 63 before converting to ASCII. The ASCII code for the semicolon is below 63, so it won't appear.
What do you mean? Retro-compatibility is a good call. Agree that it is probably not needed at this point, but something we have to keep in mind! |
|
Oh ok, perfect then. |
Problems covered by this PR
Report: https://www.dropbox.com/scl/fi/kjroygitvhc8f2kh2nhuw/Veda-Dashboard-QA-Stage-deploy-v0.6.0.paper?dl=0&rlkey=ls3fz1idxvq03hlzewfnblnnz
Broken polygons in analysis page
We were using the double pipe
||as a way to separate polygons in the url, however a polyline has naturally occurring double pipes, so when the polyline of a complex polgon had them, it was being broken into multiple polygons.Replaced the separator with a semicolon
;which is not present in the polyline.Overlay z-index
Updated the z-index of the dropdown and created a list of z-indices in the theme to simplify usage. Also converted the theme file to typescript which required updating the typings of
themeVal