Fix thumbnail error in previous analysis #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Issue: #455 |
nerik
reviewed
Mar 27, 2023
| const src = `https://api.mapbox.com/styles/v1/covid-nasa/cldac5c2c003k01oebmavw4q3/static/geojson(${encoded})/auto/480x320?access_token=${process.env.MAPBOX_TOKEN}`; | ||
| // If more than 8000 chars the request will fail. | ||
| // In this case simplify and show a bounding box. | ||
| if (encoded.length > 8000) { |
There was a problem hiding this comment.
It would be nice to store that value in a self-describing constant.
| const makeCorner = (p1, p2, p3) => ({ | ||
| type: 'Feature', | ||
| properties: { | ||
| 'stroke-width': 8, |
There was a problem hiding this comment.
Is that value related to the generated thumbnail zoom level? In that case, isn't there a risk of having visually different stroke widths?
There was a problem hiding this comment.
Nevermind this - looks good on different zoom levels.
There was a problem hiding this comment.
For completeness:
the stroke width is dependent on the image size. In this case it's 480x320 (but used in a smaller size) which is why it has such a high value (8)
nerik
reviewed
Mar 27, 2023
Co-authored-by: Erik Escoffier <erik@developmentseed.org>
|
@nerik I had definitely not understood that. 😅 Addressed |
nerik
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked this one up since it was a quick win.
When the encode polygon is too complex I'm getting the bounding box and showing the corners (kind of a scope).
I decided on the corners instead of a polygon, so that a bounding box polygon is not confused with a square-ish AOI.
Thoughts?