Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoahMP groundwater coupling through NUOPC Cap #1687

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add NoahMP groundwater coupling through NUOPC Cap #1687

wants to merge 4 commits into from
+998 −547

Conversation

danrosen25
Copy link
Contributor

@danrosen25 danrosen25 commented Feb 26, 2025 •
edited
Loading

Description

As part of the LIS-PARFLOW coupling effort this PR adds the capability of exporting water flux values to Parflow and importing the ground water storage from Parflow. It also splits the run routines for retrospective and smootherDA modes so that the NUOPC cap can call one run step at a time directly.

  • Add water flux exports and ground water storage import to Noah and NoahMP LSMs.
  • Add import and export fields to NUOPC cap
  • Fix double MPI_Finalize for internal ESMF vs external ESMF
  • Add NUOPC cap support for smootherDA
  • Split run calls for retrospective and smootherDA to individual time steps

Resolves #1686

Testcases

executed using NASA Land Coupler (NLC) on Discover Milan Nodes
baseline NLC version: 4e6c1c
baseline LISF version: 12d02d

Bit-for-bit (LIS WRFHydro Coupling)

  • coupled_tuolumne.ens020.noahmp_v4.0.1_da.nldas2 - two way coupled LIS-WRFHYDRO running ensemble disaggregation/aggregation through mediator - retrospective mode
SUCCESS: coupled_tuolumne.ens020.noahmp_v4.0.1_da.nldas2 LIS_HIST_201403020000.d01.nc
SUCCESS: coupled_tuolumne.ens020.noahmp_v4.0.1_da.nldas2 LIS_HIST_201403030000.d01.nc
SUCCESS: coupled_tuolumne.ens020.noahmp_v4.0.1_da.nldas2 LIS_HIST_201406010000.d01.nc
  • coupled_tuolumne.noahmp.nldas2 - two way coupled LIS-WRFHYDRO - retrospective mode
SUCCESS: coupled_tuolumne.noahmp.nldas2 LIS_HIST_201510020000.d01.nc
SUCCESS: coupled_tuolumne.noahmp.nldas2 LIS_HIST_201510030000.d01.nc
SUCCESS: coupled_tuolumne.noahmp.nldas2 LIS_HIST_201511010000.d01.nc

New Test Cases (LIS ParFlow Coupling)

  • coupled_lw_ens.noahmp_v4.0.1.nldas2 - two way coupled LIS-PARFLOW running ensemble disaggregation/aggregation through mediator - ensemble smoother mode
NEW: coupled_lw_ens.noahmp_v4.0.1.nldas2 LIS_HIST_200501020000.d01.nc
  • coupled_lw.noahmp_v4.0.1.nldas2 - two way coupled LIS-PARFLOW - retrospective mode
NEW: coupled_lw.noahmp_v4.0.1.nldas2 LIS_HIST_200501020000.d01.nc
NEW: coupled_lw.noahmp_v4.0.1.nldas2 LIS_HIST_200501030000.d01.nc
NEW: coupled_lw.noahmp_v4.0.1.nldas2 LIS_HIST_200501080000.d01.nc

danrosen25 and others added 2 commits February 26, 2025 16:04
@danrosen25 @fadjimaina
Add ParFlow coupling for Noah and NoahMP
795f047 
* output precip drip from LSM
* export total water flux
* import ground water storage
* add OPT_RUN value 0 to turn runoff and groundwater off
* add QINSUR, ETRANI, WTRFLX to history output

Co-Authored-By: fmaina <fadjizaouna.maina@nasa.gov>
@danrosen25
Add registry points for run step and reset
647d535 
* fix finalize for coupled runs
* add setexport for smootherDA
* split run methods for retrospective and smootherDA
* call lisinit and lisstep from NUOPC cap
* set metforc to none for external NUOPC forcing
@emkemp emkemp added the Draft label Feb 27, 2025
@danrosen25
Remove nest advance from NUOPC cap
e9c7387 
* nests are advanced within LIS
@danrosen25
Move ticktime into run step
c82ba99 
* retrospective and smootherDA
* remove time management from NUOPC Cap
* flush at end of run step
@danrosen25 danrosen25 marked this pull request as ready for review March 25, 2025 15:15
@jvgeiger jvgeiger removed the Draft label Mar 25, 2025
@jvgeiger jvgeiger self-assigned this Mar 25, 2025
@emkemp emkemp added HighPriority enhancement New feature or request labels Mar 27, 2025
@jvgeiger
Copy link
Contributor

jvgeiger commented Apr 2, 2025

@dmocko This pull request makes some changes to a few Noah implementations. These changes look good to me, but I want to give you a chance to review them and comment on them. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jvgeiger jvgeiger

Labels
enhancement New feature or request HighPriority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PARFLOW Couling to Noah and NoahMP
3 participants
@danrosen25 @jvgeiger @emkemp