Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

committing masha's notebook #189

Closed
wants to merge 4 commits into from
Closed

committing masha's notebook #189

wants to merge 4 commits into from

Conversation

jules32
Copy link
Contributor

@jules32 jules32 commented Mar 30, 2023

Hi @mjami00 I'm making this a draft pull request so we can find it more easily and have conversations about it here until we're ready to merge it

@mjami00 mjami00 marked this pull request as ready for review March 30, 2023 18:33
Copy link
Contributor

@mjami00 mjami00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay that the other external files got updated in the workflow of adding another one?
@jules32 @betolink

@jules32
Copy link
Contributor Author

jules32 commented Apr 3, 2023

Hi @mjami00 , that is an ongoing question. I think we would prefer the previous external notebooks to not be re-imported when we import a specific notebook. @betolink is that something we do by setting the assets.json process parameters to "false" or is there something further we need to change in the import function? I know you had talked about this with @cassienickles

@mjami00
Copy link
Contributor

mjami00 commented Apr 4, 2023

@jules32, I added the original notebook back to the branch but probably the workflow of adding an external file can be updated to only pulls the new notebook.

@stefaniebutland
Copy link
Member

Hi @mjami00! I'd love to help you get your notebook into the Cookbook. @betolink @cassienickles can you please advise on how to proceed, from the questions above?

@mjami00
Copy link
Contributor

mjami00 commented Jul 6, 2023

I am deleting my branch because of the existing issue with adding external notebook. A new branch will be created later to add my notebooks.

@mjami00 mjami00 closed this Jul 6, 2023
@mjami00 mjami00 deleted the import-appears branch July 6, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants