Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ArrayObject exceptions to enable improved error messaging #567

Closed
jordanpadams opened this issue Dec 2, 2022 · 1 comment · Fixed by #627
Closed

Update ArrayObject exceptions to enable improved error messaging #567

jordanpadams opened this issue Dec 2, 2022 · 1 comment · Fixed by #627
Labels
B14.0 enhancement New feature or request i&t.skip p.could-have

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Dec 2, 2022 •
edited
Loading

Asking the user to look at data type vs size is not going to go over well in the end. The checks in ArrayObject that check dimensions and index can return different (less generic) exceptions to produce a meaningful message appropriate the actual failure. If the reference to data type is data type size vs number of total bytes available then that should be simple to check as well given actual type is returned by ArrayObject.

@al-niessner totally agree. will create a separate ticket to refactor ArrayObject to provide better context to the user.

Originally posted by @jordanpadams in #566 (comment)
@jordanpadams jordanpadams mentioned this issue Apr 11, 2023
Merged
@jordanpadams
Copy link
Member Author

closed per #627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B14.0 enhancement New feature or request i&t.skip p.could-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide enhanced exception logging for Array validation per #566 NASA-PDS/validate
1 participant
@jordanpadams