Provide enhanced exception logging for Array validation per #566 #627
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
nutjob4life
reviewed
Apr 10, 2023
src/main/java/gov/nasa/pds/tools/validate/content/array/ArrayContentValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nasa/pds/tools/validate/content/array/ArrayContentValidator.java
Outdated
Show resolved
Hide resolved
nutjob4life
approved these changes
Apr 10, 2023
Love being pedantic.
nutjob4life
approved these changes
Apr 10, 2023
jordanpadams
changed the title
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Treat the various purposely thrown exceptions independently to improve the messaging. Still generates a similar error causing the same problem report but different messages. While not exhaustive, put more text in message to report the generic messages to fix the original throw to put the cause in the exception as a message.
⚙️ Test Data and/or Report
See unit tests of this PR
♻️ Related Issues
Closes #567