-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switchover to using Registry API for generating context products json #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the validate.properties to use the registry-api. Adjusted code to get all data then walk through the results as lists and maps of the JSON response object.
* updated to use `search-after` * added `useDelimiter` to Scanner in order to keep all whitespace * updated search query to ignore extraneous context products resolves #675
nutjob4life
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced just fine:
$ git checkout issue_675
branch 'issue_675' set up to track 'origin/issue_675'.
Switched to a new branch 'issue_675'
$ mvn -Dmaven.test.skip=true clean package
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
…
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.590 s
[INFO] Finished at: 2024-10-17T16:56:51-05:00
[INFO] ------------------------------------------------------------------------
66.594u 8.499s 0:36.63 204.9% 0+0k 0+0io 3201pf+0w
$ tar xzf target/validate-3.6.0-SNAPSHOT-bin.tar.gz
$ validate-3.6.0-SNAPSHOT/bin/validate -u
PDS Validate Tool Report
Configuration:
Version 3.6.0-SNAPSHOT
Date 2024-10-17T21:57:23Z
Parameters:
Targets []
Severity Level WARNING
Recurse Directories true
File Filters Used [*.xml, *.XML]
Data Content Validation on
Product Level Validation on
Max Errors 100000
Registered Contexts File /Users/kelly/Documents/Clients/JPL/PDS/Development/nasa-pds/validate/validate-3.6.0-SNAPSHOT/resources/registered_context_products.json
Summary:
1 product(s)
0 error(s)
0 warning(s)
Product Validation Summary:
1 product(s) passed
0 product(s) failed
0 product(s) skipped
1 product(s) total
Referential Integrity Check Summary:
0 check(s) passed
0 check(s) failed
0 check(s) skipped
0 check(s) total
End of Report
Completed execution in 55810 ms
al-niessner
approved these changes
Oct 17, 2024
al-niessner
previously requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this removes all solr (it should) then remove solr from pom please.
ditch solr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Query Registry API to generate the context products JSON file used for context product validation
⚙️ Test Data and/or Report
♻️ Related Issues
Resolves #675
Resolves #1034