issue #514: table not finding NaNs and Infs #588
Merged
+161
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutjob4life
approved these changes
Jan 26, 2023
nutjob4life
approved these changes
Jan 26, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
pds4-jparser uses the Java built-in Double.toString() to convert the values for tables. It means that the code is dependent upon how the JVM implements that conversion. Seems INF and NAN are no longer vogue and it now returns Infinity and NaN. Updated the available checks to include INFINITY and then convert the Double.toString().toUpperCase() for the comparison only for running with any JVM version.
⚙️ Test Data and/or Report
Added test to auto checks so look for green check below.
♻️ Related Issues
resolves #514