fix bug introduced that erroneously skips products #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2023 10:32
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
The work being done is on supposed collections. Now that we do not do it by name and haave to look for the product class in the XML had to extend the if checking to make sure it of type collection.
jordanpadams
approved these changes
Jun 1, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Seems a skip message is not appropriate. Removed it.
⚙️ Test Data and/or Report
See unit tests below
♻️ Related Issues
Closes #652