Terraform scripts and documentation to deploy ECS Task Definition for PDS Validate Tool #672
Conversation
… for PDS Validate Tool Refer to task: NASA-PDS/devops#42
ramesh-maddegoda
requested review from
jordanpadams,
tloubrieu-jpl,
nutjob4life and
al-niessner
as code owners
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
terraform/README.md
Outdated
| - AWS_SESSION_TOKEN | ||
| - AWS_DEFAULT_REGION | ||
|
|
||
| 4. Open the `terraform.tfvars` file locally and enter the value for following variables. Ensure these values match with your AWS Setup. Most of the below values can be obtained by the system admin team of your AWS account. |
There was a problem hiding this comment.
@ramesh-maddegoda this works for now, but I think we should try to figure out a more robust solution using AWS Secrets per the same issue @sjoshi-jpl is encountering with his CI/CD work. We can revise this once we come up with a better solution.
There was a problem hiding this comment.
@ramesh-maddegoda @jordanpadams agree with using AWS Secrets approach but that will be something all TF workflows will need to use once we have CI/CD established in MCP. So for now I think this look good.
| "logDriver": "awslogs", | ||
| "options": { | ||
| "awslogs-group": "/ecs/pds-validate", | ||
| "awslogs-region": "us-west-2", |
There was a problem hiding this comment.
This seems like something we may want to change at some point, but not a huge deal...
There was a problem hiding this comment.
@ramesh-maddegoda can these be passed in as env variables during workflow execution?
There was a problem hiding this comment.
@sjoshi-jpl and @jordanpadams , I externalized these values as variables that we pass in a tfvars file (same approach we used for Nucleus)
|
@sjoshi-jpl can you review this when you have a chance? |
Refer to task: NASA-PDS/devops#42
…tion. Refer to task: NASA-PDS/devops#42
🗒️ Summary
This pull request adds terraform scripts and documentation to deploy ECS Task Definition for PDS Validate Tool.
♻️ Related Issues
NASA-PDS/devops#42