Bug fix for checking delimited tables that define an object_length #687
+400
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2023 11:26
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
|
jparser PR be merged and maven artifact updated for these unit tests to pass assuming I got all the cucumber stuff right. |
|
Merged PR on pds4-jparser. Rerunning branch tests. |
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Unit tests are here but the actual fix is in NASA-PDS/pds4-jparser#97
⚙️ Test Data and/or Report
See automated unit tests
♻️ Related Issues
Closes #684