Fix offset calculation bug handling multiple file areas #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cucumber appears to be broken |
|
The feature file now traps the condition correctly. |
nutjob4life
approved these changes
Nov 8, 2023
jordanpadams
approved these changes
Nov 10, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The data object list is all of them independent of which file area * that it comes from. Added code so that offset checking resets when it transitions from one area to the next detected by filename change.
⚙️ Test Data and/or Report
Automated unit tests below all pass
♻️ Related Issues
Closes #754