Re-enable internal reference checking within a bundle on the file system #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 15, 2023 09:53
Through many of the tickets things had purposely been turned off due to a large amount of noise #368. When the reporting was turned on for this ticket got 8 warnings when the expectation was one or two. Found that the reference for some were not for this bundle. Added further filtering that the reference had to be contained in this bundle as well. Found many of the lid/lidvid checks where contains() instead of startsWith(). Change to startsWith() to prevent some messed up thing where there is a match in the middle of the string when it clearly must startWith() for correctness. This too may have some cleanup to the output.
added 3 commits
November 17, 2023 10:08
The double check ignores many of the other possible problems so moved it to check if the bad ref should be reported because it is in the same bundle
jordanpadams
approved these changes
Nov 17, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Found code that was purposely turned off and turned it back on. Increased filtering to hopefully fix the complaint enough that turned it off. Seems to be working now.
⚙️ Test Data and/or Report
Automated unit testing below should pass
♻️ Related Issues
Closes #308
#368
Closes #432