Throw ERROR when file areas point at same file #769
Conversation
In this case 3 of the 4 files reference the same file. Make sure that too many are not caught
|
Sorry, I think my work flow is different than the rest of ya. Since I am my own beat deaf drummer - yeah I make Elaine look like a good dancer - that should not be too much of a surprise. Anyway, I like to use the PR for testing since it works so well here which means I do a lot of pushes to it before letting it go. Sorry that it tricks you into thinking it is time for a review when it is not. |
|
@al-niessner no worries; it's a known and open question whether draft pull requests should send notifications. I wish GitHub would notify only when it's non-draft. I'll try to pay attention to the "draft" status, but once it's ready, you may have to re-ping me to get my review. (I practice "inbox zero".) |
There was a problem hiding this comment.
I am slightly concerned with our memory utilization having another data object that is going to need to store references for every target we come across, but I guess that is a necessary evil without some complex logic to know when you can flush the data object. Let's move forward with this and see if we encounter additional issues.
jordanpadams
changed the title
jordanpadams
changed the title
🗒️ Summary
Check during file area load if the file is already "in use" and report an error if it is.
⚙️ Test Data and/or Report
Automated unit tests below all pass
♻️ Related Issues
Closes #755